This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4 PR gdb/16959] gdb hangs in infinite recursion


On 2018-03-26 17:54, Weimin Pan wrote:
@@ -658,15 +659,14 @@ cp_print_static_field (struct type *type,
       addr = value_address (val);
       obstack_grow (&dont_print_statmem_obstack, (char *) &addr,
 		    sizeof (CORE_ADDR));
-      type = check_typedef (type);
-      cp_print_value_fields (type, value_enclosing_type (val),
+      cp_print_value_fields (real_type, value_enclosing_type (val),

As discussed previously, here we should pass the original type.

Btw, if you now have push access to the git repo, you should add yourself in the "Write After Approval" section of the gdb/MAINTAINERS file. This will help you make sure everything is set up correctly. Don't forget to include a ChangeLog entry for it and post the patch on the mailing list afterwards (mentioning that you have pushed it), you can inspire yourself from how people have done it in the past.

Simon


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]