This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Conditionally include "<windows.h>" on common/pathstuff.c (and unbreak build on mingw*)

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Eli Zaretskii <eliz at gnu dot org>
Cc: Sergio Durigan Junior <sergiodj at redhat dot com>, gdb-patches at sourceware dot org, simon dot marchi at ericsson dot com, palves at redhat dot com, brobecker at adacore dot com, christophe dot lyon at linaro dot org
Date: Fri, 02 Mar 2018 10:06:54 -0500
Subject: Re: [PATCH] Conditionally include "<windows.h>" on common/pathstuff.c (and unbreak build on mingw*)
Authentication-results: sourceware.org; auth=none
References: <CAKdteOYtFqn-4Bvd2Tekjpf+h5D-8dTSLKSPXcC7YAMRrJ1TCw@mail.gmail.com> <20180301202005.11563-1-sergiodj@redhat.com> <83h8pywqku.fsf@gnu.org>

On 2018-03-02 08:32, Eli Zaretskii wrote:

From: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>, Pedro Alves<palves@redhat.com>, Joel Brobecker<brobecker@adacore.com>, Christophe Lyon<christophe.lyon@linaro.org>, Sergio Durigan Junior<sergiodj@redhat.com>
Date: Thu,  1 Mar 2018 15:20:05 -0500

+#ifdef USE_WIN32API
+#include <windows.h>
+#endif
Isn't USE_WIN32API specific to gdbserver?  If so, perhaps it's better
to use __MINGW32__ or _WIN32 instead?


I see it defined in both gdb and gdbserver:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/configure.ac;h=698fc7b83456f8c5a63ae0050dc8ec65069290f7;hb=HEAD#l1908
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/gdbserver/configure.ac;h=99801681ff47ee8dcd9ad2e5ae282dcd113c83e4;hb=HEAD#l281

Simon

Follow-Ups:
- Re: [PATCH] Conditionally include "<windows.h>" on common/pathstuff.c (and unbreak build on mingw*)
  - From: Sergio Durigan Junior

References:
- Re: [PATCH v3 0/2] Make gdbserver work with filename-only binaries
  - From: Christophe Lyon
- [PATCH] Conditionally include "<windows.h>" on common/pathstuff.c (and unbreak build on mingw*)
  - From: Sergio Durigan Junior
- Re: [PATCH] Conditionally include "<windows.h>" on common/pathstuff.c (and unbreak build on mingw*)
  - From: Eli Zaretskii

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]