This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Conditionally include "<windows.h>" on common/pathstuff.c (and unbreak build on mingw*)


On Friday, March 02 2018, I wrote:

> On Friday, March 02 2018, Yao Qi wrote:
>
>> Sergio Durigan Junior <sergiodj@redhat.com> writes:
>>
>>> Introduced a regression when compiling for mingw*:
>>>
>>>   /gdb/common/pathstuff.c: In function 'gdb::unique_xmalloc_ptr<char>
>>>   gdb_realpath(const char*)':
>>>   /gdb/common/pathstuff.c:56:14: error: 'MAX_PATH' was not declared in this scope
>>>        char buf[MAX_PATH];
>>
>> Fedora-x86_64-w64-mingw32 catches this build failure
>> https://gdb-build.sergiodj.net/builders/Fedora-x86_64-w64-mingw32/builds/1113/steps/compile%20gdb/logs/stdio
>> but it doesn't send notification on build failure.  Could you change the
>> buildbot config to send notification on build failure?  The same as
>> other builders do.
>
> Yeah, it's on my TODO list.  I've also noticed this after Christophe
> reported the failure.  Thanks, Yao.

E-mail notifications enabled for this builder.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]