Re: [RFA] Make "bt N" print correct number of frames when using a frame filter

[Simon Marchi <simark at simark dot ca>]

On 2018-02-24 12:09 PM, Tom Tromey wrote:
>>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
> 
> Tom> There's a follow-up as well (to change the enum to use
> Tom> DEF_ENUM_FLAGS_TYPE), but that one was OK'd; but still pending since it
> Tom> touched the same code as this patch.
> 
> Tom> This is still pending review.
> 
> Tom> Some discussion here:
> Tom> https://sourceware.org/ml/gdb-patches/2017-07/msg00200.html
> 
> Tom> Original patch here:
> Tom> https://sourceware.org/ml/gdb-patches/2017-04/msg00630.html
> 
> Tom> I have a branch with this patch plus the previously-approved patch to
> Tom> change frame_filter_flags to use DEF_ENUM_FLAGS_TYPE, so if/when this
> Tom> one is ok'd, both will go in.
> 
> Ping again.
> 
> Tom
> 

The patch LGTM, considering all previously made comments are addressed.

Did you post the patch that makes frame_filter_frames an enum flags type?  I
don't see it.  If you think it's obvious enough to push it directly, make sure
to post it on the ML afterwards.

I also noticed that the frame filter flags are documented at many different places:

- above gdbpy_apply_frame_filter
- above extension_language_ops::apply_frame_filter
- above apply_ext_lang_frame_filter
- in enum frame_filter_flags

This is a recipe for them to become out of date, so I think we should only have
it in the enum declaration.  We can address that after your patches have merged.

Simon