This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA v2] (Ada) Fix frame argument printing when using auto language mode
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: Xavier Roirand <roirand at adacore dot com>, gdb-patches at sourceware dot org
- Date: Fri, 23 Feb 2018 13:37:10 +0400
- Subject: Re: [RFA v2] (Ada) Fix frame argument printing when using auto language mode
- Authentication-results: sourceware.org; auth=none
- References: <1519374774-13992-1-git-send-email-roirand@adacore.com> <86h8q8hyps.fsf@gmail.com>
> Patch is good to me, some comments below,
>
> > +extern const struct language_defn ada_language_defn;
> > +
> > static int print_field_values (struct type *, const gdb_byte *,
> > int,
> > struct ui_file *, int,
> > @@ -1208,7 +1210,7 @@ ada_val_print (struct type *type,
> > {
> > ada_val_print_1 (type, embedded_offset, address,
> > stream, recurse, val, options,
> > - current_language);
> > + &ada_language_defn);
>
> or we can use "language_def (language_ada)", so that we don't need to
> declare ada_language_defn above.
I would prefer this as well - to remain consistent with what we do
elsewhere.
--
Joel