This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] Remove a cleanup from parse_expression_for_completion

From: Tom Tromey <tom at tromey dot com>
To: Tom Tromey <tom at tromey dot com>
Cc: Simon Marchi <simon dot marchi at polymtl dot ca>, gdb-patches at sourceware dot org
Date: Mon, 19 Feb 2018 22:02:35 -0700
Subject: Re: [RFA] Remove a cleanup from parse_expression_for_completion
Authentication-results: sourceware.org; auth=none
References: <20180216230212.18553-1-tom@tromey.com> <0cbcbff07cb649201177fa01e92327e0@polymtl.ca> <87k1v846mh.fsf@tromey.com>

>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:

Tom> Here's an updated patch.  Let me know what you think.

Actually, this patch is wrong, and I didn't realize it until this
revision.  There was a failure in the buildbot report that I didn't
notice in the noise :(

There is a case in here where the NULL/empty string distinction matters.
So I think we can't use std::string but must instead use
unique_xmalloc_ptr.  I'll update the patch.

Tom

Follow-Ups:
- Re: [RFA] Remove a cleanup from parse_expression_for_completion
  - From: Tom Tromey

References:
- [RFA] Remove a cleanup from parse_expression_for_completion
  - From: Tom Tromey
- Re: [RFA] Remove a cleanup from parse_expression_for_completion
  - From: Simon Marchi
- Re: [RFA] Remove a cleanup from parse_expression_for_completion
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]