This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Move arch/tdesc.h to common/common-tdesc.h
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Alan Hayward <Alan dot Hayward at arm dot com>
- Cc: Philipp Rudo <prudo at linux dot vnet dot ibm dot com>, "gdb-patches\@sourceware.org" <gdb-patches at sourceware dot org>, nd <nd at arm dot com>
- Date: Tue, 06 Feb 2018 16:28:15 +0000
- Subject: Re: [PATCH] Move arch/tdesc.h to common/common-tdesc.h
- Authentication-results: sourceware.org; auth=none
- References: <97948063-b3db-fd3a-f62e-b552935cb8dd@arm.com> <20180201121443.43322674@ThinkPad> <59984094-96C1-4D84-89F6-384769471005@arm.com>
Alan Hayward <Alan.Hayward@arm.com> writes:
> That results in common/tdesc.h and gdbserver/tdesc.h
> That’s not a problem by itself, because we can just prefix the dir
> name as part of the include.
>
I don't see how does the name of *.c file affect the name of *.h file.
We can still use common/tdesc.h no matter what the *.c name is.
> My next set of patches will then add common/tdesc.c.
> This is slightly more tricky because we now build two tdesc.o files.
I am inclined to create common/ directory in gdb and gdbserver build
tree, and put the object files in the right directory.
> The gdbserver IPA rules will need tweaking, and I’m not sure the OBS
> list will work as it is (given it doesn’t have any dir names).
>
> Like you, I wasn’t sure if there was a naming convention for common/.
> In the end I went with the easiest solution :)
--
Yao (齐尧)