Re: [PATCH v2 0/8] Remove XML files from gdbserver

[Omair Javaid <omair dot javaid at linaro dot org>]

On 24 January 2018 at 17:29, Alan Hayward <Alan.Hayward@arm.com> wrote:

>
> > On 24 Jan 2018, at 10:57, Omair Javaid <omair.javaid@linaro.org> wrote:
> >
> > Hi Alan,
> >
> > I am failing to apply your patch series to the latest gdb sources.
> Apparently, your patch series needs a re-base over most recent gdb sources
> as there has not been a commit since these patches have been posted.
> >
> > Generally its a good idea to generate patches using git format-patch and
> send patches using git send-email. Patches need to be based off the most
> recent gdb commit that is available at the time of sending them for review.
> If you use git format-patch to generate patches from your local commits it
> would become very easy for a reviewer to just apply those patches using
> "git apply" in their local branches.
> >
> > Kindly post a patchset that works with a known version of gdb sources in
> order for your patches to be tested/reviewed upstream.
> >
>
> That’s odd.
> My patches were based off yesterday’s head (d820e164e4baccacd8d4e7e3761ec
> 547402ae828).
> I’ve just rebased my git to the latest head, and I got no conflicts or
> merge warnings.
> Looking at the diff from then until now, I can’t see any files that my
> patch touches.
> Happy to repost my rebased patches in the same way, but I suspect that’s
> not the issue.
>
> I’ve probably got something missing/wrong in the upper parts of of the
> email.
>
> Were you having trouble with a particular patch or was it all of them?
> Also, how are you getting the patch email from your email client to git?
>

I downloaded eml files. Also tried with untouched orignal email text. First
2 patches are applicable using git am. Third patch and onwards fail.

With git apply or patch command even first patch fails.


>
> I’m sending mails by opening my mail client, writing my comments, then
> copy/pasting the contents
> of a diff downloaded from a local reviewboard. That diff looks identical
> to a git format-patch or git diff.
> I’ve tried applying the first patch of the series to the latest head using
> both my patch file and contents
> of the email, and both work for me.
>

I am not sure what exactly could be wrong but it could be email client
mangling patch email or wrapping text or converting tabs/spaces.

I think you are using a windows based email client which is using CR+LF as
end line character which is incompatible with unix LF.


>
> I’ve just tested git send-mail, and it looks like I need to do some
> messing around to get that working.
> I can look at getting that working.
>
> In the meantime, I’ve pushed this branch to gdb with all my commits:
> remotes/origin/users/ahayward/xml
>
> Thanks,
> Alan.