This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Oh dear. I regret to inform you that commit 7a9dac5b3cc3b50f9733deef0a606c28b099ed1f might be unfortunate [gdb-8.1-branch]
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-buildbot at sergiodj dot net, GDB Patches <gdb-patches at sourceware dot org>
- Date: Fri, 5 Jan 2018 08:56:35 +0000
- Subject: Re: Oh dear. I regret to inform you that commit 7a9dac5b3cc3b50f9733deef0a606c28b099ed1f might be unfortunate [gdb-8.1-branch]
- Authentication-results: sourceware.org; auth=none
- References: <7a9dac5b3cc3b50f9733deef0a606c28b099ed1f-gdb-8.1-branch-breakage@gdb-build> <20180105072540.gxbdc5nhwzevlawl@adacore.com>
On Fri, Jan 5, 2018 at 7:25 AM, Joel Brobecker <brobecker@adacore.com> wrote:
>> It is a matter of great regret and sadness to inform you that commit:
>>
>> Set development mode to "off" by default.
>> 7a9dac5b3cc3b50f9733deef0a606c28b099ed1f
>>
>> might have made GDB unwell. Since I am just your Butler BuildBot,
>> I kindly ask that a human superior officer double-check this.
>>
>> Please note that if you are reading this message on gdb-patches, there might
>> be other builders broken.
>
> The patch controls the configure variab1e "development". Looking
> at the configure.ac script, I found that the selftest tests
> are only activated when it is set:
>
> if $development; then
> AC_DEFINE(GDB_SELF_TEST, 1,
> [Define if self-testing features should be enabled])
> CONFIG_OBS="$CONFIG_OBS \$(SUBDIR_UNITTESTS_OBS)"
> CONFIG_SRCS="$CONFIG_SRCS \$(SUBDIR_UNITTESTS_SRCS)"
> fi
>
> I assume the error is related to the above, since it's a link
> failure related to selftests...
>
This is about including self test cases when $development is true. It is not
related to the link failure below...
> | [...]
> | ../readline/libreadline.a ../opcodes/libopcodes.a ../bfd/libbfd.a -L./../zlib -lz ../libiberty/libiberty.a ../libdecnumber/libdecnumber.a -ldl -ldl -lncursesw -lm -ldl -lguile-2.0 -lgc -lpthread -ldl -lutil -lm -lpython2.7 -lexpat -llzma -lbabeltrace -lbabeltrace-ctf -lipt ../libiberty/libiberty.a build-gnulib/import/libgnu.a -ldl -Wl,--dynamic-list=../../binutils-gdb/gdb/proc-service.list
> | selftest.o: In function `selftests::run_tests(char const*)':
> | /home/gdb-buildbot-2/fedora-x86-64-4/fedora-x86-64/build/gdb/../../binutils-gdb/gdb/common/selftest.c:97: undefined reference to `selftests::reset()'
> | collect2: error: ld returned 1 exit status
selftest.o shouldn't be compiled when $development is false. I think selftest.o
shouldn't be put into COMMON_OBS unconditionally. I'll take a look.
--
Yao (齐尧)