This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v4 4/4] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p
- From: Simon Marchi <simon dot marchi at polymtl dot ca>
- To: Stafford Horne <shorne at gmail dot com>, GDB patches <gdb-patches at sourceware dot org>
- Cc: Eli Zaretskii <eliz at gnu dot org>
- Date: Tue, 26 Dec 2017 19:30:36 -0500
- Subject: Re: [PATCH v4 4/4] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p
- Authentication-results: sourceware.org; auth=none
- References: <20171226134832.23497-1-shorne@gmail.com> <20171226134832.23497-5-shorne@gmail.com>
On 2017-12-26 08:48 AM, Stafford Horne wrote:
> tdesc_register_in_reggroup_p in now able to handle arbitrary
> groups. This is useful when groups are created while the
> target descriptor file is received from the remote.
>
> This can be the case of a soft core target processor where
> registers/groups can change.
>
> gdb/ChangeLog:
>
> yyyy-mm-dd Franck Jullien <franck.jullien@gmail.com>
> Stafford Horne <shorne@gmail.com>
>
> * target-descriptions.c (tdesc_register_in_reggroup_p): Support
> arbitrary strings.
Please mention tdesc_use_registers in the ChangeLog. I also usually mention
changes to comments, such as the change to tdesc_reg::group's comment.
LGTM with that fixed.
Thanks!
Simon