This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 07/10] s390: Hook s390 into OSABI mechanism
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: prudo at linux dot vnet dot ibm dot com (Philipp Rudo)
- Cc: gdb-patches at sourceware dot org, arnez at linux dot vnet dot ibm dot com (Andreas Arnez), qiyaoltc at gmail dot com (Yao Qi)
- Date: Thu, 14 Dec 2017 16:44:31 +0100 (CET)
- Subject: Re: [PATCH v3 07/10] s390: Hook s390 into OSABI mechanism
- Authentication-results: sourceware.org; auth=none
Philipp Rudo wrote:
> ... I moved init_osabi so early so only the functions which are overwritten by
> the osabi (or needed for other reasons like the dwarf unwinder) are set before
> it. I hoped this would make the gdbarch_init clearer as the list before
> init_osabi is shorter and you can say for sure that all hooks set after are
> shared between all OSes. So you are not surprised with some special cases you
> don't expect. Of course this also means that if you want to overwrite a
> function you first have to move it before osabi_init. For me that is a small
> price to pay.
>
> However when you prefer the osabi_init to be done later I can move it to where
> linux_init_abi is called today. In that case i can avoid moving
> dwarf2_append_unwinders. Otherwise I will move the other
> dwarf2 related routines up. Just tell me what you prefer.
Yes, please do move init_osabi to be done later.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com