This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/Ada] fix handling of minimal symbols (UNOP_CAST and UNOP_ADDR)


> > +
> > +if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list nodebug ]] != "" } {
> > +  return -1
> > +}
> > +
> 
> Does the "nodebug" option actually exist?  I don't see it used anywhere else.
> I think the usual thing is to pass an empty options string/list.

You're right. I removed it.

> Otherwise looks great to me.  

Thanks; patch pushed in. I fixed the last typo you mentioned in
the revision log, but missed the first couple, mostly because
they are very hard to spot: My mailer treats both the same color.
And now I can't really fix it; sorry!

> Thanks much for doing this, and sorry that I didn't realize this needed
> doing when the original feature went in.

My pleasure; it's been too long since I contributed anyways ;-)

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]