This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Better make rules for IPA objects
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Alan Hayward <Alan dot Hayward at arm dot com>
- Cc: "gdb-patches\@sourceware.org" <gdb-patches at sourceware dot org>, nd <nd at arm dot com>
- Date: Tue, 14 Nov 2017 11:14:29 +0000
- Subject: Re: [PATCH] Better make rules for IPA objects
- Authentication-results: sourceware.org; auth=none
- References: <9FD839CC-67AD-43A8-B28F-11F78BB6BC94@arm.com>
Alan Hayward <Alan.Hayward@arm.com> writes:
> -%-ipa.o: ../common/%.c
> +common/%-ipa.o: ../common/%.c
> $(IPAGENT_COMPILE) $<
> $(POSTCOMPILE)
We don't have common/ directory in GDBserver build tree, so
common/%-ipa.o is useless. Secondly, this "%-ipa.o: ../common/%.c"
is removed, common/*.c files can't be built for IPA. Please remove this
change.
With your patch applied, fail to build libinproctrace.so on x86_64-linux.
g++ -std=gnu++11 -shared -fPIC -Wl,--soname=libinproctrace.so -Wl,--no-undefined -g -O2 -I. -I../../../binutils-gdb/gdb/gdbserver -I../../../binutils-gdb/gdb/gdbserver/../common -I../../../binutils-gdb/gdb/gdbserver/../regformats -I../../../binutils-gdb/gdb/gdbserver/.. -I../../../binutils-gdb/gdb/gdbserver/../../include -I../../../binutils-gdb/gdb/gdbserver/../gnulib/import -Ibuild-gnulib-gdbserver/import -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable -Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized -Wformat-nonliteral -Werror -DGDBSERVER \
-static-libstdc++ -static-libgcc -Wl,--dynamic-list=../../../binutils-gdb/gdb/gdbserver/proc-service.list -o libinproctrace.so ax-ipa.o common-utils-ipa.o errors-ipa.o format-ipa.o print-utils-ipa.o regcache-ipa.o remote-utils-ipa.o rsp-low-ipa.o tdesc-ipa.o tracepoint-ipa.o utils-ipa.o vec-ipa.o linux-amd64-ipa.o linux-x86-tdesc-ipa.o arch/amd64-ipa.o -ldl -pthread
g++: error: common-utils-ipa.o: No such file or directory
g++: error: errors-ipa.o: No such file or directory
g++: error: format-ipa.o: No such file or directory
g++: error: print-utils-ipa.o: No such file or directory
g++: error: rsp-low-ipa.o: No such file or directory
g++: error: vec-ipa.o: No such file or directory
Makefile:412: recipe for target 'libinproctrace.so' failed
This and (https://sourceware.org/ml/gdb-patches/2017-10/msg00888.html)
worry me more. You miss something important in the development
workflow to make sure your patches posted are well-tested.
--
Yao (齐尧)