This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 09/10] Make tdesc_type::u::u::fields an std::vector
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: <gdb-patches at sourceware dot org>, Simon Marchi <simon dot marchi at polymtl dot ca>
- Date: Thu, 2 Nov 2017 09:26:41 -0400
- Subject: Re: [PATCH 09/10] Make tdesc_type::u::u::fields an std::vector
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=simon dot marchi at ericsson dot com;
- References: <1509414120-14659-1-git-send-email-simon.marchi@ericsson.com> <1509414120-14659-10-git-send-email-simon.marchi@ericsson.com> <86vaitvw0z.fsf@gmail.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 2017-11-02 06:02 AM, Yao Qi wrote:
> Simon Marchi <simon.marchi@ericsson.com> writes:
>
>> This patch makes the tdesc_type::u::u::fields an std::vector of
>> tdesc_type_field. The difficulty here is that the vector is part of a
>> union. Because of this, I made fields a pointer to a vector, and
>> instantiate/destroy the vector if the type is one that uses this member
>> of the union
>
> Hi Simon,
> Did you consider remove that union by sub-class tdesc_type. We can add
> to new sub-classes, tdesc_type_with_fields and tdesc_type_vector, for
> example?
I tried, but didn't get to something I thought was nice. It should be the right
way to do it with sub-classes though, I'll try a bit harder :)
Simon