This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 06/10] Make tdesc_reg string fields std::string
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Thu, 2 Nov 2017 09:23:58 -0400
- Subject: Re: [PATCH 06/10] Make tdesc_reg string fields std::string
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=simon dot marchi at ericsson dot com;
- References: <1509414120-14659-1-git-send-email-simon.marchi@ericsson.com> <1509414120-14659-7-git-send-email-simon.marchi@ericsson.com> <86zi85vwwq.fsf@gmail.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 2017-11-02 05:43 AM, Yao Qi wrote:
> Simon Marchi <simon.marchi@ericsson.com> writes:
>
>> Doing so results in a small change in the generated tdesc. Instead of
>> passing an empty string for the group parameter of tdesc_create_reg, the
>> two modified tdesc now pass NULL. The end result should be the same.
>
> We should mention them (arc-*.c) in ChangeLog too. Patch is good to me.
Oops, you're right, fixed.
Simon