Re: [PATCH] Fix dwarf2_string_attr for -gsplit-dwarf

[Simon Marchi <simon dot marchi at polymtl dot ca>]

On 2017-10-25 05:24, Leszek Swirski via gdb-patches wrote:
> The dwarf2_string_attr did not allow DW_FORM_GNU_str_index as a form 
> for
> string types. This manifested as null strings in the namespace_name
> lookup (replaced with "(anonymous namespace)") when debugging
> Fission-compiled code.
>
> gdb/ChangeLog:
>
> 	* dwarf2read.c (dwarf2_string_attr): Allow DW_FORM_GNU_strp_alt.
>
> (cherry picked from commits 16eb6b2db49e6cf2fdca56efd37689fcc170cd37 
> and
> b33404388e5bbd8a1fddfde73cd4593ae2b557e8)
> ---
>  gdb/ChangeLog    | 4 ++++
>  gdb/dwarf2read.c | 4 +++-
>  2 files changed, 7 insertions(+), 1 deletion(-)

Hi Leszek,

It's not mentioned, but from the context of the ChangeLog change, I 
understand this is for the 8.0 branch?  8.0.1 was already released, and 
I don't know if there are plans for a 8.0.2.  But in any case, 
cherry-picking this fix doesn't hurt for anybody building from the 
gdb-8.0-branch.

Thanks,

Simon