This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 3/3] Remove cleanups from break-catch-syscall.c

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simon dot marchi at ericsson dot com>
Cc: Tom Tromey <tom at tromey dot com>, <gdb-patches at sourceware dot org>
Date: Tue, 24 Oct 2017 22:41:50 -0600
Subject: Re: [RFA 3/3] Remove cleanups from break-catch-syscall.c
Authentication-results: sourceware.org; auth=none
References: <20171018040645.7212-1-tom@tromey.com> <20171018040645.7212-3-tom@tromey.com> <280a7994-38a6-2138-b199-8902ee2651b0@ericsson.com>

Simon> It is not enough to assign holders.back ().c_str () (after having pushed the string in
Simon> the vector), because when the vector gets reallocated it can now point to stale memory.
Simon> I think we have to do it in two pass, prepare the vector of std::string, and then get
Simon> pointers to the strings.

Sorry about that.  I think I considered this after the earlier review
and believed that the resizing wouldn't affect the locations; my
thinking being that growing the vector must surely use the move
constructor to move the strings into place -- since isn't this pretty
much the whole reason rvalues even exist?  But perhaps this doesn't
happen sometimes for some reason.

Your patch seems reasonable to me.

Tom

Follow-Ups:
- Re: [RFA 3/3] Remove cleanups from break-catch-syscall.c
  - From: Pedro Alves

References:
- [RFA 1/3] Remove cleanups from prepare_execute_command
  - From: Tom Tromey
- [RFA 3/3] Remove cleanups from break-catch-syscall.c
  - From: Tom Tromey
- Re: [RFA 3/3] Remove cleanups from break-catch-syscall.c
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]