This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] commonize AARCH64 REGNUM/REGNO defines


Alan Hayward <Alan.Hayward@arm.com> writes:

Patch is good to me, some nits below,

> +#ifndef AARCH64_H

#ifndef ARCH_AARCH64_H

I know other arch/*.h don't follow this, but they should be fixed.

> +#define AARCH64_H
> +

> +
> +#endif /* aarch64.h */

/* ARCH_AARCH64_H */

> \ No newline at end of file

Add a new line at the end.

-- 
Yao (齐尧)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]