This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 7/6] More gdb.threads/attach-into-signal.exp stale stopped bits (Re: [PATCH 6/6] Drop /proc/PID/status polling from gdb.threads/attach-into-signal.exp)
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 24 Oct 2017 11:09:12 +0100
- Subject: [PATCH 7/6] More gdb.threads/attach-into-signal.exp stale stopped bits (Re: [PATCH 6/6] Drop /proc/PID/status polling from gdb.threads/attach-into-signal.exp)
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1F6708EC
- References: <1508768307-11531-1-git-send-email-palves@redhat.com> <1508768307-11531-7-git-send-email-palves@redhat.com> <86fua957l7.fsf@gmail.com>
On 10/24/2017 08:27 AM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>> gdb/testsuite/ChangeLog:
>> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>>
>> * gdb.threads/attach-into-signal.exp: Remove whole "stoppedtry"
>> loop.
>
> Patch is good to me.
>
Hmmm, noticed a related stale bit further below. Here's a patch
that removes it.
>From 8a645cfef64d4251f34f644792a756959ea440d4 Mon Sep 17 00:00:00 2001
From: Pedro Alves <palves@redhat.com>
Date: Mon, 23 Oct 2017 17:46:07 +0100
Subject: [PATCH] More gdb.threads/attach-into-signal.exp stale stopped bits
This looks as stale as the other bit that was removed in a previous
commit. The test isn't attaching to a stopped process. (And if this
were generaly necessary, then it'd be better done from within
kill_wait_spawned_process.)
gdb/testsuite/ChangeLog:
2017-10-24 Pedro Alves <palves@redhat.com>
* gdb.threads/attach-into-signal.exp (corefunc): Don't SIGCONT
test program before killing it.
---
gdb/testsuite/gdb.threads/attach-into-signal.exp | 4 ----
1 file changed, 4 deletions(-)
diff --git a/gdb/testsuite/gdb.threads/attach-into-signal.exp b/gdb/testsuite/gdb.threads/attach-into-signal.exp
index 3158b59..0af9ed5 100644
--- a/gdb/testsuite/gdb.threads/attach-into-signal.exp
+++ b/gdb/testsuite/gdb.threads/attach-into-signal.exp
@@ -113,10 +113,6 @@ proc corefunc { threadtype executable } {
# Exit and detach the process.
gdb_exit
- # Continue the program - some Linux kernels need it before -9 if the
- # process is stopped.
- remote_exec build "kill -s CONT ${testpid}"
-
kill_wait_spawned_process $test_spawn_id
}
}
--
2.5.5