This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Sporadic failures of selftest tests
- From: Pedro Alves <palves at redhat dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 20 Oct 2017 15:31:54 +0100
- Subject: Re: Sporadic failures of selftest tests
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 645AC6CB26
- References: <20171020125120.577F7D80811@oc3748833570.ibm.com>
On 10/20/2017 01:51 PM, Ulrich Weigand wrote:
> Pedro Alves wrote:
>
>> Probably the best fix would be to move away from selftest
>> entirely and convert them to unit tests instead.
>>
>> Meanwhile, how about this as an easy fix? We could try
>> playing games with making functions extern, but maybe
>> that'd break again with LTO.
>>
>> Seems to work for gdb.gdb/selftest.exp and gdb.gdb/complaints.exp
>> at least.
>>
>> (I think we can use __attribute__ directly because
>> include/ansidecl.h defines it to empty on non-gcc or
>> older gccs.)
>>
>> From: Pedro Alves <palves@redhat.com>
>> Date: 2017-10-17 15:04:11 +0100
>>
>> prevent inlining captured_command_loop
>
> Makes sense to me ...
Alright, now pushed:
https://sourceware.org/ml/gdb-patches/2017-10/msg00664.html
Thanks,
Pedro Alves