This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] GDB test suite: Add helper for locating core files
- From: Pedro Alves <palves at redhat dot com>
- To: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>, Kevin Buettner <kevinb at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 17 Oct 2017 11:01:43 +0100
- Subject: Re: [PATCH 1/2] GDB test suite: Add helper for locating core files
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 630C54E334
- References: <1505760152-28775-1-git-send-email-arnez@linux.vnet.ibm.com> <1505760152-28775-2-git-send-email-arnez@linux.vnet.ibm.com> <20171007094545.1bba5c51@pinnacle.lan> <m31smcp3b6.fsf@oc1027705133.ibm.com>
On 10/09/2017 07:46 PM, Andreas Arnez wrote:
> On Sat, Oct 07 2017, Kevin Buettner wrote:
>
> [...]
>
>> E.g. when I test your patch on my x86-64 linux box using the
>> following command...
>>
>> make check RUNTESTFLAGS="--target_board=native-gdbserver"
>>
>> ...I see 32 fewer passes than before and also one more known failure.
>>
>> Here are the passes that no longer occur when using your patch:
>
> [...]
>
>> Instead, several warnings are now printed instead:
>>
>> WARNING: Can not generate core dump on remote target.
>
> These warnings are newly introduced by the patch. They are meant to
> improve diagnostics when someone attempts to run the tests on a "real"
> remote target. I wanted to clearly document the fact that this is
> unsupported (and always was). Also, by documenting this restriction,
> maybe someone feels encouraged to lift it ;-)
Wouldn't an UNTESTED or UNSUPPORTED be better? It's what
we tend to do with other cases of unsupported/untested tests.
Those convey what happened to the testscase, and are
accounted for and an untested/unsupported count is shown at
the end of a test run, while a count of warnings isn't.
Thanks,
Pedro Alves