This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH v2] symlookup: improves symbol lookup when a file is specified.
- From: "Tedeschi, Walfred" <walfred dot tedeschi at intel dot com>
- To: "palves at redhat dot com" <palves at redhat dot com>, "simon dot marchi at polymtl dot ca" <simon dot marchi at polymtl dot ca>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 16 Oct 2017 13:23:40 +0000
- Subject: RE: [PATCH v2] symlookup: improves symbol lookup when a file is specified.
- Authentication-results: sourceware.org; auth=none
- Dlp-product: dlpe-windows
- Dlp-reaction: no-action
- Dlp-version: 11.0.0.116
- References: <1507727728-30540-1-git-send-email-walfred.tedeschi@intel.com>
Hi all,
> +set lib_opts debug
> +set exec_opts [list debug shlib_load
> +additional_flags=-DSHLIB_NAME=\"${lib_dlopen1}\"
> +additional_flags=-DSHLIB_NAME2=\"${lib_dlopen2}\"]
> +
> +if { [gdb_compile_shlib $libsrc1 $libobj1 $lib_opts] != ""
> + || [gdb_compile_shlib $libsrc2 $libobj2 $lib_opts] != ""
> + || [gdb_compile $srcfile $binfile executable $exec_opts] != ""} {
> + untested "failed to compile"
> + return -1
> +}
I have revmoved the code below from my sandbox.
Next review will not have that.
> +
> +if { [gdb_compile_shlib ${srcdir}/${subdir}/${lib1}.c \
> + ${libobj1} \
> + ${lib_opts} ] != "" } {
> + return -1
> +}
> +if { [gdb_compile_shlib ${srcdir}/${subdir}/${lib2}.c \
> + ${libobj2} \
> + ${lib_opts} ] != "" } {
> + return -1
> +}
> +if { [gdb_compile "${srcdir}/${subdir}/${executable}.c" \
> + [standard_output_file ${executable}] \
> + executable \
> + [list debug shlib=-ldl]]
> + != ""} {
> + return -1
> +}
> +
Would it help to have a branch with those changes?
Thanks and regards,
/Fred
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928