This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] GDB test suite: Add helper for locating core files
- From: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Kevin Buettner <kevinb at redhat dot com>, gdb-patches at sourceware dot org
- Date: Thu, 12 Oct 2017 19:00:11 +0200
- Subject: Re: [PATCH 1/2] GDB test suite: Add helper for locating core files
- Authentication-results: sourceware.org; auth=none
- References: <1505760152-28775-1-git-send-email-arnez@linux.vnet.ibm.com> <1505760152-28775-2-git-send-email-arnez@linux.vnet.ibm.com> <20171007094545.1bba5c51@pinnacle.lan> <m31smcp3b6.fsf@oc1027705133.ibm.com> <a02b8961-d8c3-a0a9-9887-23a24e63962d@redhat.com>
On Thu, Oct 12 2017, Pedro Alves wrote:
> On 10/09/2017 07:46 PM, Andreas Arnez wrote:
>
>> @@ -5883,7 +5883,7 @@ proc run_and_get_core {binfile {arg ""}} {
>> # specified. Return that path name, or "" if no core file was found.
>>
>> proc find_core {binfile coredir {destcore ""}} {
>> - if {[is_remote target]} {
>> + if {![isnative]} {
>> warning "Can not access remote core file."
>> return ""
>> }
>
> This seems incorrect to me. "isnative" only checks
> if the build and target _triplets_ are the same. So
> foo-linux-gnu gdb x foo-linux-gnu gdbserver on separate
> machine still returns isnative==true.
Exactly, that's why I originally wrote is_remote instead. And I also
wondered why the core dump tests check isnative. Does anyone run the
testsuite on a native remote setup?
> I think the real problem is that the native-gdbserver board
> returns true to is_remote, when I think it shouldn't.
>
> Doing that alone results in fallout in the testsuite, of
> course. I'm seeing if fixing it is doable.
Right, this seems all a bit mixed up to me, similar to the confusing
remote_file and remote_exec operations in core_find.
--
Andreas