This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC][08/19] Target FP: Use target format throughout expression parsing
- From: Simon Marchi <simark at simark dot ca>
- To: Joel Brobecker <brobecker at adacore dot com>, Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 9 Oct 2017 17:14:53 -0400
- Subject: Re: [RFC][08/19] Target FP: Use target format throughout expression parsing
- Authentication-results: sourceware.org; auth=none
- References: <20170905182110.3ED3BD8086F@oc3748833570.ibm.com> <20171009181215.tx5pxfnpuxt7ikcy@adacore.com>
On 2017-10-09 02:12 PM, Joel Brobecker wrote:
> One C++ thing I did notice but forgot to report...
>
>> +floatformat_from_string (const struct floatformat *fmt, gdb_byte *out,
>> + std::string in)
>
> Again, to be double-checked, but I think you want to pass the argument
> by reference in this case. Otherwise, you may end up having an overhead
> with might not be necessary due to the creation of a copy of the string
> being passed as argument here.
>
Indeed, it's good practice to pass constant strings (or other objects) as
const references (const std::string &in).
Simon