Re: [RFC][08/19] Target FP: Use target format throughout expression parsing

["Ulrich Weigand" <uweigand at de dot ibm dot com>]

Joel Brobecker wrote:
> > - Ada: This used to check sizeof (DOUBLEST) to determine which
> >   type to use for floating-point literal.  This seems questionable
> >   to being with (since DOUBLEST is quite unrelated to target formats),
> >   and in any case we need to get rid of DOUBLEST.  I'm now simply
> >   always using the largest type (builtin_long_double) -- if there's
> >   a better way (not sure what the Ada standard defines here), this
> >   can be updated.
> 
> I did a bit of archeology, and it looks like this was BMT (Before My
> Time). But looking at the code, I *think* this may have been related
> to the fact that we decode the value and store it in host-side format,
> and it looks like the code is trying to find the best target-side type
> match so as to avoid having to deal with too much precision if the host
> isn't capable of it in the first place??? As you say, this might be
> questionable, just trying to think the reasons behind it.
> 
> In any case, I looked at your changes, and they seem fine to me.
> In fact, I welcome the simplification ;-).

Excellent, thanks for the verification!

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com