Re: [PATCH v2 5/5] Extend "set cwd" to work on gdbserver

[Sergio Durigan Junior <sergiodj at redhat dot com>]

On Friday, September 22 2017, Pedro Alves wrote:

> On 09/21/2017 12:49 AM, Sergio Durigan Junior wrote:
>> On Wednesday, September 20 2017, Pedro Alves wrote:
>
>>> This all looks stale to me.
>> 
>> Indeed, sorry about this mistake.  I will rewrite the entry as follows:
>> 
>> * New features in the GDB remote stub, GDBserver
>> 
>>   ** GDBserver is now able to enter a directory before starting an
>>      inferior.
>> 
>>      The user can set the desired working directory to be used by the
>>      remote inferior on GDB, using the new "set cwd" command, which
>>      will instruct GDB to tell GDBserver about this directory change
>>      the next time an inferior is run.
>
> I still think this is talking too much in terms of implementation
> detail, but I'll reply again to v3.

I'm curious to know why.  I'll wait for your review.

>> In this case, I'd have to check for ![is_remote host], is that right?
>> 
>>> I don't understand the explicit check for gdbserver in
>>> skip_gdbserver_tests.
>> 
>> I was thinking of the following scenario:
>> 
>> - The users wants to skip gdbserver tests
>> 
>> - He runs the test as "make check-gdb TESTS=gdb.base/set-cwd.exp"
>> 
>> - Because of the unconditional call to "skip_gdbserver_tests", the test
>>   doesn't run at all, even though the test *should* run because the user
>>   hasn't specified any remote board, etc.
>
> And that's what I don't understand at all.  skip_gdbserver_tests
> is useful for the gdb.server/ tests that spawn gdbserver even
> if testing with the local/unix board, i.e., the native target.
> But this testcase isn't spawning gdbserver manually, unlike e.g., the
> gdb.server/ tests.  It just runs against whatever target is
> specified by --target_board.

Ah.  Then I *really* misunderstood these concepts.  Thanks for
clarifying this to me.  v3 still has the call to "skip_gdbserver_tests",
so please ignore it.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/