This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 45/67] Constify cd_command
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 21 Sep 2017 08:47:57 -0400
- Subject: Re: [RFA 45/67] Constify cd_command
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0E83FC0733E3
- References: <20170921051023.19023-1-tom@tromey.com> <20170921051023.19023-46-tom@tromey.com>
On Thursday, September 21 2017, Tom Tromey wrote:
> ChangeLog
> 2017-09-20 Tom Tromey <tom@tromey.com>
>
> * cli/cli-cmds.h (cd_command): Constify.
> * cli/cli-cmds.c (cd_command): Constify.
I've been meaning to do that. This is OK by me. Thanks,
> ---
> gdb/ChangeLog | 5 +++++
> gdb/cli/cli-cmds.c | 2 +-
> gdb/cli/cli-cmds.h | 2 +-
> 3 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c
> index 4cc9fa6..d87722f 100644
> --- a/gdb/cli/cli-cmds.c
> +++ b/gdb/cli/cli-cmds.c
> @@ -392,7 +392,7 @@ pwd_command (char *args, int from_tty)
> }
>
> void
> -cd_command (char *dir, int from_tty)
> +cd_command (const char *dir, int from_tty)
> {
> int len;
> /* Found something other than leading repetitions of "/..". */
> diff --git a/gdb/cli/cli-cmds.h b/gdb/cli/cli-cmds.h
> index 1122a97..34d19f5 100644
> --- a/gdb/cli/cli-cmds.h
> +++ b/gdb/cli/cli-cmds.h
> @@ -110,7 +110,7 @@ int is_complete_command (struct cmd_list_element *cmd);
>
> /* Exported to gdb/main.c */
>
> -extern void cd_command (char *, int);
> +extern void cd_command (const char *, int);
>
> /* Exported to gdb/top.c and gdb/main.c */
>
> --
> 2.9.4
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/