This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFA 39/67] Constify some commands in ax-gdb.c
- From: Tom Tromey <tom at tromey dot com>
- To: gdb-patches at sourceware dot org
- Cc: Tom Tromey <tom at tromey dot com>
- Date: Wed, 20 Sep 2017 23:09:55 -0600
- Subject: [RFA 39/67] Constify some commands in ax-gdb.c
- Authentication-results: sourceware.org; auth=none
- References: <20170921051023.19023-1-tom@tromey.com>
ChangeLog
2017-09-20 Tom Tromey <tom@tromey.com>
* ax-gdb.c (maint_agent_printf_command, agent_command)
(agent_eval_command): Constify.
---
gdb/ChangeLog | 5 +++++
gdb/ax-gdb.c | 13 ++++---------
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/gdb/ax-gdb.c b/gdb/ax-gdb.c
index c4bf2a6..52ca081 100644
--- a/gdb/ax-gdb.c
+++ b/gdb/ax-gdb.c
@@ -158,8 +158,6 @@ static void gen_expr_binop_rest (struct expression *exp,
struct axs_value *value,
struct axs_value *value1,
struct axs_value *value2);
-
-static void agent_command (char *exp, int from_tty);
/* Detecting constant expressions. */
@@ -2661,7 +2659,7 @@ agent_command_1 (const char *exp, int eval)
}
static void
-agent_command (char *exp, int from_tty)
+agent_command (const char *exp, int from_tty)
{
agent_command_1 (exp, 0);
}
@@ -2671,7 +2669,7 @@ agent_command (char *exp, int from_tty)
expression. */
static void
-agent_eval_command (char *exp, int from_tty)
+agent_eval_command (const char *exp, int from_tty)
{
agent_command_1 (exp, 1);
}
@@ -2680,12 +2678,11 @@ agent_eval_command (char *exp, int from_tty)
that does a printf, and display the resulting expression. */
static void
-maint_agent_printf_command (char *exp, int from_tty)
+maint_agent_printf_command (const char *cmdrest, int from_tty)
{
struct cleanup *old_chain = 0;
struct expression *argvec[100];
struct frame_info *fi = get_current_frame (); /* need current scope */
- const char *cmdrest;
const char *format_start, *format_end;
struct format_piece *fpieces;
int nargs;
@@ -2697,11 +2694,9 @@ maint_agent_printf_command (char *exp, int from_tty)
if (overlay_debugging)
error (_("GDB can't do agent expression translation with overlays."));
- if (exp == 0)
+ if (cmdrest == 0)
error_no_arg (_("expression to translate"));
- cmdrest = exp;
-
cmdrest = skip_spaces (cmdrest);
if (*cmdrest++ != '"')
--
2.9.4