This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Allow to link with ncursesw
- From: Pedro Alves <palves at redhat dot com>
- To: Matthias Klose <doko at ubuntu dot com>, gdb-patches at sourceware dot org
- Date: Wed, 20 Sep 2017 19:39:01 +0100
- Subject: Re: [patch] Allow to link with ncursesw
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6A45B806AC
- References: <bb52db91-88bc-164e-bbea-b53a14dde34e@ubuntu.com>
On 09/13/2017 11:29 AM, Matthias Klose wrote:
> Triggered by https://launchpad.net/bugs/1275210, to be able to cope with UTF-8
> characters in gdbtui. Ok for the trunk?
>
> Matthias
>
> * configure.ac: Search ncursesw before ncurses.
> Check ncursesw/ncurses.h before ncurses/ncurses.h.
> * gdb_curses.h: Include <ncursesw/ncurses.h>
> * config.in, configure: Regenerate.
>
This sounds a bit scary if readline (or Python?) links with ncurses.
Looking both upstream readline sources and our local copy in the tree,
I don't see anything checking for ncursesw. Looking around for
ncurses + ncursesw, I found:
https://bugs.python.org/issue9408
https://bugs.python.org/issue7384
"Python3 now links _curses.so to ncurses library (bytes version) instead
of ncursesw library (unicode version) if readline is linked to ncurses."
....
"Thomas Dickey recommended not to load readline+ncurses and ncursesw
at the same time."
And:
https://bugs.mageia.org/show_bug.cgi?id=2156
bugs.debian.org/cgi-bin/bugreport.cgi?bug=602720
I see you've been involved with all this before.
Did you reach out to readline/bash, see if they're willing
to try ncursesw before ncurses too? Don't we need at least
a local patch to our local readline copy, to avoid breaking
those that use it and have it link with ncurses?
Thanks,
Pedro Alves