This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH, gdb/testsuite] Fix calls in gdb.arch/thumb2-it.exp
- From: Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>
- To: GDB Patches <gdb-patches at sourceware dot org>
- Date: Wed, 6 Sep 2017 16:26:41 +0100
- Subject: [PATCH, gdb/testsuite] Fix calls in gdb.arch/thumb2-it.exp
- Authentication-results: sourceware.org; auth=none
Hi,
Tests in gdb.arch/thumb2-it.exp call functions defined in assembly
without type debugging information. Since
7022349d5c86bae74b49225515f42d2e221bd368 this triggers an error which
leads to many tests to FAIL. This patch cast the call to indicate the
return type of the functions when calling them.
ChangeLog entry is as follows:
*** gdb/testsuite/ChangeLog ***
2017-09-06 Thomas Preud'homme <thomas.preudhomme@arm.com>
* gdb.arch/thumb2-it.exp: Cast call to assembly defined function.
All tests in that exp file PASS after that change.
Is this ok for master?
Best regards,
Thomas
diff --git a/gdb/testsuite/gdb.arch/thumb2-it.exp b/gdb/testsuite/gdb.arch/thumb2-it.exp
index ab0dae38e302cdfef0232780612ea9a2f36d7f54..e100d068b3a92f24fb1bd0f8ffaedcc58d7512a8 100644
--- a/gdb/testsuite/gdb.arch/thumb2-it.exp
+++ b/gdb/testsuite/gdb.arch/thumb2-it.exp
@@ -58,7 +58,7 @@ proc test_it_block { func } {
return
}
- gdb_test "call ${func}()" "Breakpoint.*@ Setup.*" "$func, call"
+ gdb_test "call (int) ${func}()" "Breakpoint.*@ Setup.*" "$func, call"
set expected 0
set reached 0
@@ -155,7 +155,7 @@ for { set i 1 } { $i <= 8 } { incr i } {
}
gdb_breakpoint "*it_breakpoints"
-gdb_test "call it_breakpoints()" "Breakpoint.*"
+gdb_test "call (int) it_breakpoints()" "Breakpoint.*"
for { set i 1 } { $i <= 7 } { incr i } {
test_it_break ${i}
}