This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/3] Move command lines types/declarations to cli-script.h
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Mon, 4 Sep 2017 13:28:32 +0100
- Subject: Re: [PATCH 1/3] Move command lines types/declarations to cli-script.h
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D0F4619D28C
- References: <1504388179-579-1-git-send-email-simon.marchi@ericsson.com> <1504388179-579-2-git-send-email-simon.marchi@ericsson.com>
On 09/02/2017 10:36 PM, Simon Marchi wrote:
> I think it would make more sense if the types and function declarations
> related to command lines were in cli-script.h rather than defs.h, since
> the related function definitions are in cli-script.c.
>
> I had to add a few includes here and there. I also had to rename the
> "lines" parameter of command_lines_deleter::operator(), because ncurses
> has a "#define lines ..." that was interfering when cli-script.h is
> included by some TUI source files that also include ncurses header files.
LGTM.
Thanks,
Pedro Alves