This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Oh dear. I regret to inform you that commit 'remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type' might be unfortunate

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Joel Brobecker <brobecker at adacore dot com>
Cc: gdb-patches at sourceware dot org
Date: Sat, 26 Aug 2017 15:18:28 +0200
Subject: Re: Oh dear. I regret to inform you that commit 'remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type' might be unfortunate
Authentication-results: sourceware.org; auth=none
References: <E1dlPHW-0007LM-Eg@kwanyin.sergiodj.net> <20170826123906.wg5s7qsm65lklk5s@adacore.com>

On 2017-08-26 14:39, Joel Brobecker wrote:

Hello,

On Fri, Aug 25, 2017 at 08:48:58PM -0400, gdb-buildbot@sergiodj.netwrote:

My lords, ladies, gentlemen, members of the public.

It is a matter of great regret and sadness to inform you that commit:

	remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type
	988f6b3dc615173d6d78a76ac26c109b4582da74

might have made GDB unwell.  Since I am just your Butler BuildBot,
I kindly ask that a human superior officer double-check this.


My change only touches a static function in ada-lang.c, while
the error is reported inside sparc64-tdep.  Maybe an earlier commit?

Yes, it was an earlier commit. Weimin Pan has submitted patches to fixit, the latest version (needs to be reviewed) being:


  https://sourceware.org/ml/gdb-patches/2017-08/msg00495.html

Simon

References:
- Re: Oh dear. I regret to inform you that commit 'remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type' might be unfortunate
  - From: Joel Brobecker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]