This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 1/2] Fix two regressions in scalar printing
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 14 Aug 2017 15:02:47 +0100
- Subject: Re: [RFA 1/2] Fix two regressions in scalar printing
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 27D49C0B7708
- References: <20170713123400.28917-1-tom@tromey.com> <20170713123400.28917-2-tom@tromey.com> <22c48f9e-ec2c-850d-91d3-c6a3ea8cdb11@redhat.com> <871spjufnv.fsf@pokyo> <e341effa-cdc4-a876-9f19-f2ad4d3fe0ff@redhat.com> <871sow9scp.fsf@tromey.com>
On 07/31/2017 11:03 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> Yeah, that seems OK to me GDB-output-wise. "You get what you ask
> Pedro> for".
>
> Here is an updated version of this patch, that (I think) implements what
> was discussed in this thread.
>
> I regtested it on the buildbot.
>
> Let me know what you think.
Sorry for dropping the ball on this. I wanted to be sure that
we have tests for the
(gdb) p /u -1
$1 = 4294967295
(gdb) p /d (unsigned long long) -1
$2 = -1
etc. issues discussed earlier. Do you know whether there's some tests for
that already somewhere, but might have simply been missed before for
running both patches together?
> +# Regression test for PR gdb/21675
> +proc test_radices {} {
> + gdb_test "print/o 16777211" " = 077777773"
> + gdb_test "print/d 1.5" " = 1\[^.\]"
> + gdb_test "print/u 1.5" " = 1\[^.\]"
What's the reason for the "\[^.\]" part of the regexes?
What's that trying to match? Why not simply " = 1" ?
> +}
> +
> proc test_print_all_chars {} {
> global gdb_prompt
Thanks,
Pedro Alves