This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/3] GDBserver self tests
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Fri, 11 Aug 2017 18:09:52 +0100
- Subject: Re: [PATCH 3/3] GDBserver self tests
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DFD15C0B2A41
- References: <1502465408-24668-1-git-send-email-yao.qi@linaro.org> <1502465408-24668-4-git-send-email-yao.qi@linaro.org>
On 08/11/2017 04:30 PM, Yao Qi wrote:
>
> 2017-05-26 Yao Qi <yao.qi@linaro.org>
>
> * gdb.server/unittest.exp: New.
This is missing from the patch.
> +* New features in the GDB remote stub, GDBserver
> +
> + ** New "--selftest" command line option runs some GDBserver self
> + tests. These self tests are disabled in release.
"disabled in release mode." or "disabled in releases." ?
> @@ -3357,6 +3359,7 @@ gdbserver_usage (FILE *stream)
> " Options:\n"
> " vCont, Tthread, qC, qfThreadInfo and \n"
> " threads (disable all threading packets).\n"
> + " --selftest Run self tests.\n"
> "\n"
> "For more information, consult the GDB manual (available as on-line \n"
> "info or a printed manual).\n");
I wonder whether "gdbserver --help" should really advertise --selftests,
given it's a maintenance command and essentially does nothing in
release mode.
> +@cindex @option{--selftest}
> +The @option{--wrapper} option runs the self tests in @code{gdbserver}:
> +
Pasto: "--wrapper" should be "--selftest".
Thanks,
Pedro Alves