Re: [PATCH v2] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode

[Ruslan Kabatsayev <b7 dot 10110111 at gmail dot com>]

On 5 August 2017 at 09:29, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: b7.10110111@gmail.com
>> Cc: Ruslan Kabatsayev <b7.10110111@gmail.com>
>> Date: Fri,  4 Aug 2017 22:27:18 +0300
>>
>> From: Ruslan Kabatsayev <b7.10110111@gmail.com>
>>
>> Currently, "layout asm" is not so useful as "layout src" with Single-Key mode:
>> you have to use multi-key commands like "ni" and "si" to do single-stepping.
>> This patch adds, in addition to "next" and "step" commands, corresponding
>> assembly-level ones - "nexti" and "stepi" - to Single-Key mode, with the
>> shortcuts of "o" (from "step Over") and "i" (from "Step Into") respectively.
>
> The "i" in "nexti" and "ni" stands for "instruction", not "into".
Here I refer to the "i" the shortcut, not "i" in the "nexti" command.
We do need some way of memorizing the shortcut key, don't we? See the
discussion in the thread of the previous version of the patch. I may
have to make the wording clearer in the documentation though.
>
> Personally, I'm not sure this is worth it, but then I don't use TUI
> frequently enough to have my opinion count.
>
> If the code change is accepted, the documentation review is below.
>
>> gdb/ChangeLog:
>>
>>       * tui/tui.c: Add "nexti" and "stepi" to the tui_commands list
>>       * doc/gdb.texinfo: Document the new shortcuts in Single-Key mode
>
> The ChangeLog entries need to state the function/data structure in
> which the change is made (node name for the manual).  Also,
> gdb.texinfo has a separate ChangeLog in gdb/doc/.
>
>> +@kindex o @r{(SingleKey TUI key)}
>> +@item o
>> +nexti. The letter @samp{o} stands for ``step Over''.
>         ^^
> We leave two spaces between sentences.
>
> Thanks.