This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH] Import setenv and unsetenv from gnulib
- From: Anton Kolesov <Anton dot Kolesov at synopsys dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Francois Bedard <Francois dot Bedard at synopsys dot com>, Sergio Durigan Junior <sergiodj at redhat dot com>
- Date: Tue, 4 Jul 2017 18:06:28 +0000
- Subject: RE: [PATCH] Import setenv and unsetenv from gnulib
- Authentication-results: sourceware.org; auth=none
- References: <87shid8rt3.fsf@redhat.com> <20170703162737.8386-1-Anton.Kolesov@synopsys.com> <CAH=s-POJzGx1Ab28a56ru2S6jHugH-gikJJgFziiR4ZRSc0-Tg@mail.gmail.com>
> > Patch [1] broke a build on MinGW hosts, because MinGW doesn't provide
> > POSIX functions setenv () and unsetenv (). This can be fixed by using
> > implementations from gnulib.
> >
> > [1] https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=9a6c7d9c0
> >
>
> We need commit hash and subject only, like
>
> 9a6c7d9c0 (C++ify gdb/common/environ.c)
>
> Did you run regression test on x86-linux? If there is no regression, patches is
> good to me.
If I run "make check-gdb", I don't see any obvious new errors from this patch.
Unfortunately results are a little bit volatile - some tests sporadically fail even
if I run them with same GDB build and sources, even without this patch - I've run
testsuite five times and got five similar, but different results.
Selftests pass on x86_64-linux. On Windows with this patch there is a failure in
iconv sefltest, which seems unrelated (was present even when I've tried to use
putenv directly instead of importing gnulib module).
Anton
>
> --
> Yao (齐尧)