This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 09/25] Use target_desc fields expedite_regs and xmltarget ifndef IN_PROCESS_AGENT
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Wed, 28 Jun 2017 18:42:48 +0100
- Subject: Re: [PATCH 09/25] Use target_desc fields expedite_regs and xmltarget ifndef IN_PROCESS_AGENT
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 6CA99C0467C0
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6CA99C0467C0
- References: <1497256916-4958-1-git-send-email-yao.qi@linaro.org> <1497256916-4958-10-git-send-email-yao.qi@linaro.org> <bde9fae8-85ea-8383-0d33-fabbcafb40ba@redhat.com>
On 06/28/2017 05:15 PM, Pedro Alves wrote:
> On 06/12/2017 09:41 AM, Yao Qi wrote:
>> struct target_desc is used by both GDBserver and IPA, but fields expedite_regs
>> and xmltarget are only used in GDBserver, so this patch wraps these two fields
>> by ifndef IN_PROCESS_AGENT. This patch also changes regformats/regdat.sh to
>> generate .c files in this way too.
>
> OK.
Actually, I tried building the series at some intermediate patch,
and noticed that the build was broken. This is the first patch
that breaks it:
...
amd64-linux.c: In function ‘void init_registers_amd64_linux()’:
amd64-linux.c:103:11: error: ‘struct target_desc’ has no member named
‘expedite_regs’
result->expedite_regs = expedite_regs_amd64_linux;
^
amd64-linux.c:104:11: error: ‘struct target_desc’ has no member named
‘xmltarget’
result->xmltarget = xmltarget_amd64_linux;
^
...
Thanks,
Pedro Alves