This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 02/25] Adjust the order of 32bit-linux.xml and 32bit-sse.xml in i386/i386-linux.xml

On 06/20/2017 10:20 AM, Yao Qi wrote:
> This patch doesn't change the registers layout in gdbserver, because
> gdb/regformats/i386/i386-linux.dat isn't affected by this patch.  

...

> It
> determines the register layout for i386-linux, in which "orig_eax" is
> already put the end of list, thanks to sort-regs.xsl.

Ok, that's for gdbserver, while I was worrying more about gdb, but
it's a good hint.  The feature xml files hardcode register numbers,
and the move ends up being a nop.  Good.

> 
> This patch only changes the order of iterating features and registers in
> GDB, however, the order doesn't matter.
> 

> The GDB's understanding to g/G packet layout is not changed, verified by
> "maintenance print remote-registers",

Great, thanks for confirming.

Thanks,
Pedro Alves
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]