This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH 5/5] Add support for Intel PKRU register to GDB and GDBserver.
- From: "Tedeschi, Walfred" <walfred dot tedeschi at intel dot com>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>, "Sturm, Michael" <michael dot sturm at intel dot com>
- Cc: "mark dot kettenis at xs4all dot nl" <mark dot kettenis at xs4all dot nl>, "palves at redhat dot com" <palves at redhat dot com>, "eliz at gnu dot org" <eliz at gnu dot org>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 20 Jun 2017 07:07:33 +0000
- Subject: RE: [PATCH 5/5] Add support for Intel PKRU register to GDB and GDBserver.
- Authentication-results: sourceware.org; auth=none
- Dlp-product: dlpe-windows
- Dlp-reaction: no-action
- Dlp-version: 10.0.102.7
- References: <1485954205-18536-1-git-send-email-michael.sturm@intel.com> <1485954205-18536-6-git-send-email-michael.sturm@intel.com> <b1aa5ba9bac9989251fcba737441ffa6@polymtl.ca>
-----Original Message-----
From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Simon Marchi
Sent: Monday, June 19, 2017 9:15 PM
To: Sturm, Michael <michael.sturm@intel.com>
Cc: mark.kettenis@xs4all.nl; palves@redhat.com; eliz@gnu.org; gdb-patches@sourceware.org
Subject: Re: [PATCH 5/5] Add support for Intel PKRU register to GDB and GDBserver.
On 2017-02-01 14:03, Michael Sturm wrote:
> @@ -281,10 +281,12 @@ $(outdir)/i386/i386-avx-avx512.dat:
> i386/32bit-core.xml i386/32bit-avx.xml \
> i386/32bit-avx512.xml
> $(outdir)/i386/i386-avx-avx512-linux.dat: i386/32bit-core.xml
> i386/32bit-avx.xml \
> i386/32bit-linux.xml i386/32bit-avx512.xml
> -$(outdir)/i386/i386-avx-mpx-avx512.dat: i386/32bit-core.xml
> i386/32bit-avx.xml \
> - i386/32bit-mpx.xml i386/32bit-avx512.xml
> -$(outdir)/i386/i386-avx-mpx-avx512-linux.dat: i386/32bit-core.xml
> i386/32bit-avx.xml \
> - i386/32bit-linux.xml i386/32bit-mpx.xml
> i386/32bit-avx512.xml
> +$(outdir)/i386/i386-avx-mpx-avx512-pku.dat: i386/32bit-core.xml
Hi Michael,
I just noticed that there is a backslash missing at the end of a line here ^ (in features/Makefile). That causes an error when doing make clean; make. I would have added it myself, but it also changes the resulting dat files, so I think it's better if you have a look and see if that's right.
Thanks,
Simon
> + i386/32bit-avx.xml i386/32bit-mpx.xml i386/32bit-avx512.xml
> \
> + i386/32bit-pkeys.xml
> +$(outdir)/i386/i386-avx-mpx-avx512-pku-linux.dat: i386/32bit-core.xml
> \
> + i386/32bit-avx.xml i386/32bit-mpx.xml i386/32bit-avx512.xml
> \
> + i386/32bit-pkeys.xml i386/32bit-linux.xml
> $(outdir)/i386/i386-mmx.dat: i386/32bit-core.xml
> $(outdir)/i386/i386-mmx-linux.dat: i386/32bit-core.xml
> i386/32bit-linux.xml
> $(outdir)/i386/amd64-avx.dat: i386/64bit-core.xml i386/64bit-avx.xml
Hi Simon,
Michael I am taking over Michaels activities. May I prepare as an obvious patch?
Thanks and regards,
/Fred
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928