This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: MinGW compilation warnings in libiberty's xstrndup.c
- From: Pedro Alves <palves at redhat dot com>
- To: DJ Delorie <dj at redhat dot com>, Eli Zaretskii <eliz at gnu dot org>
- Cc: gcc-patches at gcc dot gnu dot org, gdb-patches at sourceware dot org
- Date: Fri, 19 May 2017 23:28:32 +0100
- Subject: Re: MinGW compilation warnings in libiberty's xstrndup.c
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7A928624CF
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7A928624CF
- References: <xnd1b4ik8l.fsf@greed.delorie.com>
On 05/19/2017 10:56 PM, DJ Delorie wrote:
>
> Eli Zaretskii <eliz@gnu.org> writes:
>> It should use HAVE_STRNLEN instead, because that's the only
>> strnlen-related macro defined in config.g when strnlen is probed by
>> the configure script.
>
> Ah, but gcc's configure defines HAVE_DECL_STRNLEN. Header guards need
> to be coordinated across all the users, not just libiberty.
>
The "user" in this case is libiberty itself.
Thanks,
Pedro Alves