This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: GDB 7.99.91 MinGW compilation warning in tui.c
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 13 May 2017 11:11:35 +0300
- Subject: Re: GDB 7.99.91 MinGW compilation warning in tui.c
- Authentication-results: sourceware.org; auth=none
- References: <20170504194442.63AAF60B72@joel.gnat.com> <83mvancrze.fsf@gnu.org> <CAH=s-PM+ZXw6T9+2feqp0tr479bnwFFDUTgkpoF-5QOk3Qi9pQ@mail.gmail.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Yao Qi <qiyaoltc@gmail.com>
> Date: Tue, 9 May 2017 11:17:25 +0100
> Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
>
> On Mon, May 8, 2017 at 4:01 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> > tui/tui.c: In function 'void tui_enable()':
> > tui/tui.c:430:39: warning: ISO C++ forbids converting a string constant to 'char*' [-Wwrite-strings]
> > s = newterm ("unknown", stdout, stdin);
> > ^
> > I fixed this by explicitly casting "unknown" to 'char *' -- is that
> > the right fix? Is it OK to push that fix?
> >
>
> Yes, I think so, we've done this before
> https://sourceware.org/ml/gdb-patches/2017-04/msg00032.html
Thanks, pushed.