This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 08/10] Class-ify lm_info_svr4
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Fri, 28 Apr 2017 17:00:13 +0100
- Subject: Re: [PATCH 08/10] Class-ify lm_info_svr4
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 959B9C08E280
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 959B9C08E280
- References: <20170426224706.27988-1-simon.marchi@ericsson.com> <20170426225139.313-8-simon.marchi@ericsson.com>
On 04/26/2017 11:51 PM, Simon Marchi wrote:
> This patch makes lm_info_svr4 a "real" class. It initializes fields,
> uses bool and replaces XCNEW/xfree with new/delete.
>
> The memcpy in svr4_copy_library_list is replaced by a usage of the
> default copy constructor.
LGTM.
Thanks,
Pedro Alves