This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 00/10] Make lm_info class hierarchy
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: <gdb-patches at sourceware dot org>
- Cc: Simon Marchi <simon dot marchi at ericsson dot com>
- Date: Wed, 26 Apr 2017 18:46:56 -0400
- Subject: [PATCH 00/10] Make lm_info class hierarchy
- Authentication-results: sourceware.org; auth=none
- Authentication-results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=ericsson.com;
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
This patch series makes a class hierarchy out of all the lm_info
implementations. This is done to address the problem identified by Pedro in
[1].
What I did corresponds to suggestion #1 in Pedro's message. #3 would probably
be better, but it's not straightforward. Some implementations keep their own
list of lm_info, separate from the global (per pspace) so_list. So if we
eliminate the lm_info classes and replace them with classes that extend
so_list, it's not clear what we should do with these private lists.
So, suggestion #1 is a small step forward, and puts us in good position if we
want to do #3 one day. We would then have to change the lm_info_* classes to
extend so_list instead of lm_info (and probably rename them).
This series went through the buildbot (in its almost final form), it contains
code that the buildbot doesn't test, and that is difficult for most of us to
test.
[1] https://sourceware.org/ml/gdb-patches/2017-04/msg00559.html
Simon Marchi (10):
Standardize darwin's lm_info
Make various lm_info implementations inherit from a base class
Class-ify lm_info_aix
Class-ify lm_info_dsbt
Fix indentation of lm_info_frv
Class-ify lm_info_frv
Class-ify lm_info_target
Class-ify lm_info_svr4
Class-ify lm_info_darwin
Class-ify lm_info_windows
gdb/nto-tdep.c | 35 +---------------
gdb/solib-aix.c | 110 +++++++++++++++++++++-----------------------------
gdb/solib-darwin.c | 34 ++++++++--------
gdb/solib-dsbt.c | 38 ++++++++++--------
gdb/solib-frv.c | 109 ++++++++++++++++++++++++++------------------------
gdb/solib-svr4.c | 115 ++++++++++++++++++++++++++---------------------------
gdb/solib-svr4.h | 23 +++++++++++
gdb/solib-target.c | 114 ++++++++++++++++++++++++++--------------------------
gdb/solist.h | 10 +++--
gdb/windows-nat.c | 54 +++++++++++++++----------
10 files changed, 319 insertions(+), 323 deletions(-)
--
2.11.0