This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Make environ.exp run on all platforms (and create info-program.exp)



On 04/25/2017 03:47 PM, Sergio Durigan Junior wrote:
Changes from v1:

- Fixed regex of "show environment".

- Make regexes of "info program" more flexible (for bare-metal
  targets).


This has been on my TODO list for a while.  There's a really old bug
about this (PR testsuite/8595), and there was no reason for
environ.exp to be specific for hppa* targets.  So this patch removes
this constraint, modernizes the testcase, and cleans up some things.
Most of the tests remained, and some were rewritten (especially the
one that checks if "show environment" works, which is something kind
of hard to do).

As a bonus, I'm adding a separated info-program.exp file containing
all the tests related to "info program" that were present on
environ.exp.

Tested locally, everything still passes.

gdb/testsuite/ChangeLog:
2017-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>

	PR testsuite/8595
	* gdb.base/environ.exp: Make test available in all architectures.
	Move bits related to "info program" testing to
	gdb.base/info-program.exp.  Rewrite tests to use the two new
	procedures mentione below.
	(test_set_show_env_var) New procedure.
	(test_set_show_env_var_equal): Likewise.
	* gdb.base/info-program.exp: New file.
---
 gdb/testsuite/ChangeLog                 |  11 ++
 gdb/testsuite/gdb.base/environ.exp      | 302 ++++++--------------------------
 gdb/testsuite/gdb.base/info-program.exp |  45 +++++
 3 files changed, 105 insertions(+), 253 deletions(-)
 create mode 100644 gdb/testsuite/gdb.base/info-program.exp

I get full passes with gdb.base/environment.exp now, but gdb.base/info-program.exp is still failing.

FAIL: gdb.base/info-program.exp: info program after run to main
FAIL: gdb.base/info-program.exp: info program after next
FAIL: gdb.base/info-program.exp: info program after deleting all breakpoints

By removing the initial \t from the patterns of these 3 tests, i get full passes for gdb.base/info-program.exp as well.

Luis


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]