This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Make "bt N" print correct number of frames when using a frame filter
- From: Tom Tromey <tom at tromey dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Tue, 25 Apr 2017 18:17:14 -0600
- Subject: Re: [RFA] Make "bt N" print correct number of frames when using a frame filter
- Authentication-results: sourceware.org; auth=none
- References: <20170423160446.17062-1-tom@tromey.com> <87zif4s5po.fsf@redhat.com>
>> + /* Set this flag if a "More frames" message is to be printed. */
>> + PRINT_MORE_FRAMES = 16,
>> };
Sergio> Not that I want you to fix this, but I like when bitflags are set using
Sergio> the "1 << X" notation. Oh, well...
I added a patch for this and I also changed this code to use
DEF_ENUM_FLAGS_TYPE, which seems better. I'll send this change
separately.
>> + assert ((flags & PRINT_MORE_FRAMES) != 0);
Sergio> gdb_assert here, right?
Oops, yes. I made this change.
Tom