This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 5/8] Python: Introduce gdb.RecordGap class

From: Yao Qi <qiyaoltc at gmail dot com>
To: Tim Wiederhake <tim dot wiederhake at intel dot com>
Cc: gdb-patches at sourceware dot org, markus dot t dot metzger at intel dot com, brobecker at adacore dot com
Date: Fri, 21 Apr 2017 15:50:09 +0100
Subject: Re: [PATCH v2 5/8] Python: Introduce gdb.RecordGap class
Authentication-results: sourceware.org; auth=none
References: <1492771786-26372-1-git-send-email-tim.wiederhake@intel.com> <1492771786-26372-6-git-send-email-tim.wiederhake@intel.com>

Tim Wiederhake <tim.wiederhake@intel.com> writes:

> As discussed here: https://sourceware.org/ml/gdb-patches/2017-04/msg00157.html
>
> A gap is not an instruction and it should not pretend to be one.

Hi Tim,
Patch is good to me, a comment on commit log.  Could you extract the
discussion summary in the url into the commit log? so people can read
them in git log easily.

-- 
Yao (齐尧)

References:
- [PATCH v2 0/8] Python bindings for GDB record
  - From: Tim Wiederhake
- [PATCH v2 5/8] Python: Introduce gdb.RecordGap class
  - From: Tim Wiederhake

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]