This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb passes and returns incorrect values when dealing with small array on Sparc
- From: Pedro Alves <palves at redhat dot com>
- To: vladimir dot mezentsev at oracle dot com, gdb-patches at sourceware dot org
- Date: Tue, 18 Apr 2017 15:54:23 +0100
- Subject: Re: [PATCH] gdb passes and returns incorrect values when dealing with small array on Sparc
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A1FA58FCE4
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A1FA58FCE4
- References: <1490721669-12560-1-git-send-email-vladimir.mezentsev@oracle.com> <5a3397ae-e986-8a36-13ba-ed2cfeb68a12@redhat.com> <58DBE2F2.4080504@oracle.com>
Hi Vladimir,
On 03/29/2017 05:38 PM, Vladimir Mezentsev wrote:
> On 03/29/2017 02:56 AM, Pedro Alves wrote:
>> Hi Vladimir,
>>
>> gdb development happens on a separate list - gdb-patches@. Please resend
>> the patch there. TIA!
>
> Done.
>>
>> A question I'll have is whether this had any observable effect in
>> testsuite
>> results, other than "no regressions". I.e., whether there were
>> progressions,
>> or whether we're missing testsuite coverage.
>
> 6 tests ( from gdb/testsuite/gdb.base/gnu_vector.exp) failed on
> sparc64-Linux and on sparc-Solaris in 32- and 64-bit mode.
> Now all these tests passed.
>
> gdb/testsuite/gdb.base/gnu_vector.exp has 117 different cases for small
> (and not small) arrays and structures.
This information should be included in the commit log.
> I think we don't need an additional test in gdb/testsuite.
Agreed.
Thanks,
Pedro Alves