This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/8] C++fy thread_apply_all_command

From: Yao Qi <qiyaoltc at gmail dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: gdb-patches at sourceware dot org
Date: Thu, 13 Apr 2017 11:06:13 +0100
Subject: Re: [PATCH 3/8] C++fy thread_apply_all_command
Authentication-results: sourceware.org; auth=none
References: <1491954673-29172-1-git-send-email-palves@redhat.com> <1491954673-29172-4-git-send-email-palves@redhat.com>

Pedro Alves <palves@redhat.com> writes:

> yyyy-mm-dd  Pedro Alves  <palves@redhat.com>
>
> 	* thread.c: Include <algorithm>.
> 	(thread_array_cleanup): Delete.
> 	(scoped_inc_dec_ref): New class.
> 	(live_threads_count): New function.
> 	(set_thread_refcount): Delete.
> 	(tp_array_compar_ascending): Now a bool.
> 	(tp_array_compar): Convert to a std::sort comparison function.
> 	(thread_apply_all_command): Use std::vector and scoped_inc_dec_ref
> 	and live_threads_count.

LGTM.

-- 
Yao (齐尧)

References:
- [PATCH 0/8] Fix removing inferiors from within "thread apply" commands
  - From: Pedro Alves
- [PATCH 3/8] C++fy thread_apply_all_command
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]