This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 10/14] C++ify mi_parse

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Tom Tromey <tom at tromey dot com>
Cc: gdb-patches at sourceware dot org
Date: Mon, 10 Apr 2017 21:12:09 -0400
Subject: Re: [RFA 10/14] C++ify mi_parse
Authentication-results: sourceware.org; auth=none
References: <20170408201208.2672-1-tom@tromey.com> <20170408201208.2672-11-tom@tromey.com>

On 2017-04-08 16:12, Tom Tromey wrote:

diff --git a/gdb/mi/mi-parse.h b/gdb/mi/mi-parse.h
index b11e5d3..eb19260 100644
--- a/gdb/mi/mi-parse.h
+++ b/gdb/mi/mi-parse.h
@@ -41,6 +41,15 @@ enum mi_command_type

 struct mi_parse
   {
+    mi_parse ()
+    {
+    }


Nit:

mi_parse () = default;

But otherwise, LGTM.

Simon

References:
- [RFA 00/14] miscellaneous C++-ificiation
  - From: Tom Tromey
- [RFA 10/14] C++ify mi_parse
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]