This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 17/18] -Wwrite-strings: The Rest

From: Pedro Alves <palves at redhat dot com>
To: John Baldwin <jhb at freebsd dot org>, gdb-patches at sourceware dot org
Date: Wed, 5 Apr 2017 13:59:15 +0100
Subject: Re: [PATCH 17/18] -Wwrite-strings: The Rest
Authentication-results: sourceware.org; auth=none
References: <1491326751-16180-1-git-send-email-palves@redhat.com> <1491326751-16180-18-git-send-email-palves@redhat.com> <6118858.lO2ajWnfox@ralph.baldwin.cx>

On 04/04/2017 07:22 PM, John Baldwin wrote:
> On Tuesday, April 04, 2017 06:25:50 PM Pedro Alves wrote:
>> This is the remainder boring constification that all looks more of less
>> borderline obvious IMO.
>>
>> gdb/ChangeLog:
>> yyyy-mm-dd  Pedro Alves  <palves@redhat.com>
>>
>> 	* fbsd-tdep.c (fbsd_core_pid_to_str): Constify.
> 
> Tiny nit: this isn't actually changed in this patchset (was going to quickly
> eyeball it).  

Whooops, sorry about that.  Fixed locally.

> Perhaps the changelog is stale from you breaking the
> pid_to_str target method out into its own patch?

That's exactly what happened.

Thanks for taking a look!

-- 
Pedro Alves

References:
- [PATCH 00/18] gdb: Enable -Wwrite-strings (aka remove -Wno-write-strings)
  - From: Pedro Alves
- [PATCH 17/18] -Wwrite-strings: The Rest
  - From: Pedro Alves
- Re: [PATCH 17/18] -Wwrite-strings: The Rest
  - From: John Baldwin

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]